-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeleteView doesn't work for projects which don't use TempEntityClass #485
Comments
koeaw
added
bug
Something isn't working (properly, as expected, at all)
UI-UX
Appearance, coherence, usability of user-facing parts (frontend, user interface)
labels
Dec 13, 2023
We agreed to split this in two to reduce complexity:
|
Not exactly sure which of the two parts this issue relates to- according to the title probably the first. This would be great to have soon, as deleting an instance is a rather important feature (and its a small fix) |
Ah, right! Thx for the reminder. I'll reduce #458 down to what's needed to fix the first obstacle (TempEntityClass). |
koeaw
added a commit
that referenced
this issue
Dec 20, 2023
Changes model referenced by GenericEntitiesDeleteView from TempEntityClass to RootObject. Closes #485
This was referenced Dec 20, 2023
koeaw
added a commit
that referenced
this issue
Dec 20, 2023
In GenericEntitiesDeleteView, override get_queryset() method instead of referencing a specific (parent) model to get at the object-to-be-deleted. Closes #485
b1rger
pushed a commit
that referenced
this issue
Dec 21, 2023
In GenericEntitiesDeleteView, override get_queryset() method instead of referencing a specific (parent) model to get at the object-to-be-deleted. Closes #485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue for WIP PR #458.
Describe the bug
As I started to work on #437, I noticed I couldn't get
GenericEntitiesDeleteView
to work at all because it still refers toTempEntityClass
.Once I'd fixed that, the confirmation template for deletion, which is not entity-specific but shared between views, wouldn't show me any information on what exactly I was deleting.
While looking at the HTML, I also noticed that it was generally off in places, e.g. buttons which belong together don't sit next to each other for some reason, convoluted wording for the "Cancel" button, a nonfunctional close button,...
The text was updated successfully, but these errors were encountered: