Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeleteView doesn't work for projects which don't use TempEntityClass #485

Closed
koeaw opened this issue Dec 13, 2023 · 3 comments · Fixed by #458 or #520
Closed

DeleteView doesn't work for projects which don't use TempEntityClass #485

koeaw opened this issue Dec 13, 2023 · 3 comments · Fixed by #458 or #520
Assignees
Labels
bug Something isn't working (properly, as expected, at all) easy Should be an easy fix UI-UX Appearance, coherence, usability of user-facing parts (frontend, user interface)

Comments

@koeaw
Copy link
Contributor

koeaw commented Dec 13, 2023

Issue for WIP PR #458.

Describe the bug
As I started to work on #437, I noticed I couldn't get GenericEntitiesDeleteView to work at all because it still refers to TempEntityClass.

Once I'd fixed that, the confirmation template for deletion, which is not entity-specific but shared between views, wouldn't show me any information on what exactly I was deleting.

While looking at the HTML, I also noticed that it was generally off in places, e.g. buttons which belong together don't sit next to each other for some reason, convoluted wording for the "Cancel" button, a nonfunctional close button,...

@koeaw koeaw added bug Something isn't working (properly, as expected, at all) UI-UX Appearance, coherence, usability of user-facing parts (frontend, user interface) labels Dec 13, 2023
@koeaw koeaw self-assigned this Dec 13, 2023
@koeaw
Copy link
Contributor Author

koeaw commented Dec 13, 2023

We agreed to split this in two to reduce complexity:

  • the first/existing PR should solve the faulty model reference in the view and (if applicable) fix the reference to the entity in the template
  • the other issues with the template (formatting, styling, tweaking of information displayed to users,...) should go into a second, independent PR

@b1rger
Copy link
Contributor

b1rger commented Dec 20, 2023

Not exactly sure which of the two parts this issue relates to- according to the title probably the first. This would be great to have soon, as deleting an instance is a rather important feature (and its a small fix)

@b1rger b1rger added the easy Should be an easy fix label Dec 20, 2023
@koeaw
Copy link
Contributor Author

koeaw commented Dec 20, 2023

Ah, right! Thx for the reminder.

I'll reduce #458 down to what's needed to fix the first obstacle (TempEntityClass).

@koeaw koeaw linked a pull request Dec 20, 2023 that will close this issue
koeaw added a commit that referenced this issue Dec 20, 2023
Changes model referenced by GenericEntitiesDeleteView
from TempEntityClass to RootObject.

Closes #485
koeaw added a commit that referenced this issue Dec 20, 2023
In GenericEntitiesDeleteView, override get_queryset() method
instead of referencing a specific (parent) model to get at the
object-to-be-deleted.

Closes #485
b1rger pushed a commit that referenced this issue Dec 21, 2023
In GenericEntitiesDeleteView, override get_queryset() method
instead of referencing a specific (parent) model to get at the
object-to-be-deleted.

Closes #485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (properly, as expected, at all) easy Should be an easy fix UI-UX Appearance, coherence, usability of user-facing parts (frontend, user interface)
Projects
None yet
2 participants