"name_label_filter" filtering of entities broken

[koeaw]

In list view, searching fields which use name_label_filter in APIS_ENTITIES settings results in this error:

AssertionError at /apis/entities/entity/ENTITY_URL/list/
Expected parent FilterSet 'apis_core.apis_entities.filters.AdHocEntityListFilter' to have a '.name_label_filter()' method.

I remember something about better filtering being implemented and even seem to remember mention of name_label_filter (at a JF?!) but don't remember details and currently don't have time to investigate beyond the 5 minutes I just spent looking for hints. (Thx to which I know now that e.g. the filter still exists and was moved from apis_entities to utils – 4 months ago.)

We haven't changed anything to do with filters on our end, AFAIK.

[b1rger]

from apis_core.utils.filters import name_label_filter

APIS_ENTITIES = {
   "UnknownEntity": {
        "list_filters": {
            "name": { "method": name_label_filter },
        }
    }
}

(Once apis_entities is refactored to use the generic app, you can simply create your own filterset, as documented in the django-filters documentation)

[koeaw]

Ok, so I'm getting one step further with the above after changing the import statement to:

from apis_core.utils.filtermethods import name_label_filter

but now I'm getting a FieldError because we don't actually use a label field. Is it possible this wasn't required before?

But yeah, we don't need any other filters for now other than one for partial strings instead of exact matches, which I believe Django provides out-of-the-box anyway, so I might just wait until the refactor is finished.

[koeaw]

Closing this as I'm ccurrently working on replacing APIS_ENTITIES in our app.