Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit GenericTable's sequence #716

Closed
koeaw opened this issue Mar 11, 2024 · 0 comments · Fixed by #738 or #745
Closed

Inherit GenericTable's sequence #716

koeaw opened this issue Mar 11, 2024 · 0 comments · Fixed by #738 or #745
Labels
feature-request Request for adaptation of existing functionality or new feature refactor Clean-up or restructuring of code for readability/speed/simplicity

Comments

@koeaw
Copy link
Contributor

koeaw commented Mar 11, 2024 •
edited
Loading

We don't currently inherit from GenericTable.meta.sequence in tables which inherit from GenericTable, like PropertyTable or TripleTable, when it would make sense to do so for consistency (in the appearance of the buttons) and to avoid redundancy.

As a result, the action buttons currently do not appear in the expected view-edit-delete order in those two tables but are inserted in the order they are defined in GenericTable, which is edit-(desc-)delete-view.

Related: #715

Screenshot:
Screenshot 2024-03-11 at 13-41-09 Title Placeholder
@koeaw koeaw added triage Issue has yet to be assigned labels to clarify its purpose or focus feature-request Request for adaptation of existing functionality or new feature refactor Clean-up or restructuring of code for readability/speed/simplicity and removed triage Issue has yet to be assigned labels to clarify its purpose or focus labels Mar 11, 2024
@koeaw koeaw removed their assignment Mar 20, 2024
b1rger added a commit that referenced this issue Mar 21, 2024
@b1rger
fix(apis_relations): reuse GenericTable.Meta.sequence for tables
628eeb3 
This way we use the same order of fields as in the other tables
inheriting from GenericTable.

Closes: #716
@b1rger b1rger mentioned this issue Mar 21, 2024
Merged
b1rger added a commit that referenced this issue Mar 22, 2024
@b1rger
fix(apis_relations): reuse GenericTable.Meta.sequence for tables
b15e587 
This way we use the same order of fields as in the other tables
inheriting from GenericTable.

Closes: #716
@github-actions github-actions bot mentioned this issue Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request Request for adaptation of existing functionality or new feature refactor Clean-up or restructuring of code for readability/speed/simplicity
Projects
None yet
Milestone
No milestone
1 participant
@koeaw