Redundant/leftover functions? – related_entity_name, related_arbitrary_model_name #790
Comments
b1rger
added a commit
that referenced
this issue
Jul 1, 2024
The `filtermethods` module contained a couple of unused filtermethods that were used in old APIS models and referenced hardcoded field names. They were all replaced by more flexible approaches by now. The `construct_lookup` method can be useful and was therefore salvaged and moved to the `utils.helpers` module. Closes: #790
b1rger
added a commit
that referenced
this issue
Jul 1, 2024
The `filtermethods` module contained a couple of unused filtermethods that were used in old APIS models and referenced hardcoded field names. They were all replaced by more flexible approaches by now. The `construct_lookup` method can be useful and was therefore salvaged and moved to the `utils.helpers` module. The `test_filtermethods` module was renamed accordingly. Closes: #790
b1rger
added a commit
that referenced
this issue
Jul 22, 2024
The `utils.filtermethods` module contained a couple of unused filtermethods that were used in old APIS models and referenced hardcoded field names. They were all replaced by more flexible approaches by now. The `construct_lookup` method that was part of the module can be useful and was therefore salvaged and moved to the `utils.helpers` module. The `test_filtermethods` module was renamed accordingly. Closes: #790
b1rger
added a commit
that referenced
this issue
Jul 22, 2024
The `utils.filtermethods` module contained a couple of unused filtermethods that were used in old APIS models and referenced hardcoded field names. They were all replaced by more flexible approaches by now. The `construct_lookup` method that was part of the module can be useful and was therefore salvaged and moved to the `utils.helpers` module. The `test_filtermethods` module was renamed accordingly. Closes: #790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
IIRC during
RootObject's field name change (deprecated_name), we touched onrelated_entity_nameand/orrelated_arbitrary_model_name, which resulted in it/them not getting modified. I'm guessing these can now be dropped since we cannot assume that entities have anamefield.Relatedly, there is no way to rewrite
related_entity_nameto be flexible/generic with regard to which field gets looked up, is there? If I understand correctly, its idea is to look up objects in relationships regardless of which side of a triple they are on (subject, object).related_property_namebelow it seems to have a similar purpose, to simplify lookups, just for relationships.... Just came across these again in the context of querying relationships for custom API endpoints.
The text was updated successfully, but these errors were encountered: