Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Ruff linter config to import sorting with isort #913

Closed
koeaw opened this issue Jun 5, 2024 · 1 comment · Fixed by #1154
Closed

Extend Ruff linter config to import sorting with isort #913

koeaw opened this issue Jun 5, 2024 · 1 comment · Fixed by #1154
Assignees
Labels
tooling Tools, workflows, integrations etc. relevant to project maintenance, deployment, collaboration

Comments

@koeaw
Copy link
Contributor

koeaw commented Jun 5, 2024

See Frischmuth's pyproject.toml ("I" is the relevant ruleset for import sorting).

This should get tested locally by team members before adding it to main – there were some (non-obvious) discrepancies between how Ruff picked up on settings on my system vs. how it did (not) on GitHub. ... IIRC my Ruff infered src and known-first-party without them having to be set explicitly.

@koeaw koeaw added the tooling Tools, workflows, integrations etc. relevant to project maintenance, deployment, collaboration label Jun 5, 2024
@b1rger
Copy link
Contributor

b1rger commented Sep 6, 2024

there were some (non-obvious) discrepancies between how Ruff picked up on settings on my system vs. how it did (not) on GitHub. ... IIRC my Ruff infered src and known-first-party without them having to be set explicitly

could you explain what exactly that means? I fail to see exactly what exactly I should be testing for

@b1rger b1rger mentioned this issue Sep 6, 2024
@b1rger b1rger self-assigned this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Tools, workflows, integrations etc. relevant to project maintenance, deployment, collaboration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants