Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to new person and author data structure that matches that of corpus files #99

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

MauPalantir
Copy link
Contributor

PLs review if I don't break anything for other projects, but I would think these are all occurrences of feature lists and sample texts, which are only used heavily in Tunocent. Maybe Old Vicav data needs to be updated to reflect the listPerson element, but I am not sure about what vicav backend version it is using right now.

@MauPalantir MauPalantir requested a review from simar0at November 28, 2024 13:59
@MauPalantir MauPalantir changed the title Adapt to new person list structure that matches that of corpus files Fix #97 Adapt to new person list structure that matches that of corpus files Nov 28, 2024
@MauPalantir MauPalantir changed the title Fix #97 Adapt to new person list structure that matches that of corpus files Fixes #97 Adapt to new person list structure that matches that of corpus files Nov 28, 2024
@MauPalantir MauPalantir linked an issue Nov 28, 2024 that may be closed by this pull request
@MauPalantir MauPalantir changed the title Fixes #97 Adapt to new person list structure that matches that of corpus files Fix #97 Adapt to new person list structure that matches that of corpus files Nov 28, 2024
@MauPalantir MauPalantir changed the title Fix #97 Adapt to new person list structure that matches that of corpus files Fix #97 Adapt to new person and author data structure that matches that of corpus files Nov 28, 2024
@MauPalantir MauPalantir linked an issue Nov 28, 2024 that may be closed by this pull request
@MauPalantir MauPalantir changed the title Fix #97 Adapt to new person and author data structure that matches that of corpus files Adapt to new person and author data structure that matches that of corpus files Nov 28, 2024
@simar0at simar0at temporarily deployed to review-fix-informants December 9, 2024 13:06 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review-fix-informants-tunocent December 9, 2024 13:06 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review-fix-informants-shawi December 9, 2024 13:06 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review-fix-informants-wibarab December 9, 2024 13:06 — with GitHub Actions Inactive
@simar0at simar0at had a problem deploying to review-fix-informants December 9, 2024 13:06 — with GitHub Actions Error
@simar0at simar0at had a problem deploying to review-fix-informants-wibarab December 9, 2024 13:07 — with GitHub Actions Error
@simar0at simar0at had a problem deploying to review-fix-informants-shawi December 9, 2024 13:07 — with GitHub Actions Error
@simar0at simar0at had a problem deploying to review-fix-informants December 9, 2024 13:07 — with GitHub Actions Error
@simar0at simar0at had a problem deploying to review-fix-informants-tunocent December 9, 2024 13:07 — with GitHub Actions Error
@dasch124
Copy link
Member

dasch124 commented Dec 9, 2024

Thanks, @simar0at, for the addition! I think, it would still be wise to restrict tei:respStmt to tei:resp='author'

@simar0at simar0at had a problem deploying to review-fix-informants December 9, 2024 13:11 — with GitHub Actions Failure
@simar0at simar0at temporarily deployed to review-fix-informants-shawi December 9, 2024 14:02 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review-fix-informants December 9, 2024 14:02 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review-fix-informants-tunocent December 9, 2024 14:02 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review-fix-informants-wibarab December 9, 2024 14:02 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review-fix-informants December 9, 2024 14:02 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review-fix-informants-shawi December 9, 2024 14:02 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review-fix-informants-wibarab December 9, 2024 14:02 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapt to new persName structure Speaker ID and demographics are missing from search results
3 participants