-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibilty with Zim 0.67-rc2 #11
Comments
Today the stable v0.67 was released. Here's the changelog. Would be great to finally have Zimsearch working with the latest Zim release. |
Confirmed as broken as of zim-desktop-wiki 2d0ead5a9736267766dfa669f2e78d27a2a5c110 thru tag 0.67. I've been playing around with zimsearch trying to fix up searches (using the approved zim.seach interface, no less), but invoking the result is proving harder. Working on it. |
Without your great plugin using Zim on Gnome just doesn't feel right :) Please let me know, if I somehow can help you in adapting your plugin to the newest Zim version. I'm coding illiterate, but maybe could help you otherwise. For instance, this guy recently released a Zim plugin (comments) for Albert. Maybe it could help you to solve your problem. Best wishes! |
That should fix things for 0.67 😄
Sorry this has taken so long to fix. Thanks again for the report. |
Huge thanks!!
Although I have a quite fast PC, the new approach feels very sluggish to me. It takes about 5 seconds for the results to appear. At the beginning I even thought, that this plugin doesn't work at all, because the previous versions showed the results instantly. Only by accident I saw the new results, when the Gnome-Shell stayed open a little longer than usual. IMHO, the current approach is too slow to have a practical value. Additionally, the current search results aren't sorted according to their weight/frequency, as done in Zim, when using "search in notebook" or "go/jump to page". I really think, that it's absolutely sufficient to search only for the page title, not the content itself, like it was before. In that case you would significantly speed up the searching process. In case of need, I also can imagine separating the results for the page titles and the content. So the page results should be at the beginning and if there is still place left, then content results could be shown. But I think, that the creator of Zim had a very good reason to separate both searching methods and your great plugin should also do it that way. I'm looking forward to your answer. |
Sound like lots of separate issues. Mind raising them as separate issues so they can be worked on separately? Slight confession: I've been using Xfce and Kupfer recently, since Debian testing/unstable broke GNOME in a few places that matter to me. It'd be nice to get Kupfer talking to D-Bus SearchProvider2 services - I wonder if anyone's done that yet? That'd give me an impetus to work on the new speed issues. |
It seems, that Zimsearch is currently not compatible with the 0.67-rc2 version of Zim, that was released recently.
I've followed your instructions, the installation process went well, but don't received any results in the Gnome-Shell. Of course I've enabled both the Gnome-Shell search plugin and the Zim one. Restarted, but without any effect. Happens with Ubuntu Gnome 17.04.
All files seem to be on their place:
The text was updated successfully, but these errors were encountered: