Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support artifact coordinates for parent, rather than relative path #5

Open
cprice404 opened this issue Jun 22, 2016 · 2 comments
Open

Comments

@cprice404
Copy link
Contributor

I'm interested in adding support for specifying an artifact coordinate tuple as the parent project (e.g. [myorg/myparent "1.0.0"], instead of a relative file path. I'm happy to hack on the code for this; wondering if that would be considered for inclusion, and/or if this plugin is still being maintained? I can also just fork and release a new plugin based on that if this is no longer maintained.

@achin
Copy link
Owner

achin commented Jun 22, 2016

Hi Chris,

Thanks! I'm glad to hear that people are still using this plugin.

I'm not really maintaining it anymore, but I'm happy to accept any pull
request and publish a release.

Just let me know what you'd like to do.

Best,
Alex
On Jun 22, 2016 6:18 PM, "Chris Price" [email protected] wrote:

I'm interested in adding support for specifying an artifact coordinate
tuple as the parent project (e.g. [myorg/myparent "1.0.0"], instead of a
relative file path. I'm happy to hack on the code for this; wondering if
that would be considered for inclusion, and/or if this plugin is still
being maintained? I can also just fork and release a new plugin based on
that if this is no longer maintained.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#5, or mute the thread
https://github.com/notifications/unsubscribe/AAE8gui2iN0kjmL1TkTLSiz4kl0QXgjBks5qObSdgaJpZM4I8R5V
.

@cprice404
Copy link
Contributor Author

Filed PR #6 with a working implementation of this. It depends on some other PRs that I've filed against lein core, so for now, just hoping to allow my co-workers to test it. Assuming the lein patches are accepted upstream and there is a version of lein released that contains them, I would love to see this merged and released. Will keep you posted; thanks @achin .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants