fix: fix docs og gen failing for versioned and localized docs #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Castle [email protected]
Description:
This PR modifies docusaurus-og's getHtmlPath function to use doc.metadata.slug instead of doc.metadata.permalink
Related Issue(s):
N/A
Changes Included:
Implementation Details:
Currently, getHtmlPath of docs.plugin.ts for docusaurus-og uses doc.metadata.permalink, but this causes undesired behavior when localized or versioned docs are used. This is because this.context.outDir already contains the locale and version in the path, which is again passed by doc.metadata.permalink. This leads to double versions and/or locales in the path passed to Docusaurus, which causes this error:
Testing:
Testing was done by using the docusaurus-og on a site with locales other than the default locale. The change allowed preview images to generate and a successful build for both the default locale and the additional locale.
Checklist: