Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t disable trackpad if only mouse available is touchscreen #452

Closed
usr-sse2 opened this issue Aug 10, 2019 · 3 comments
Closed

Don’t disable trackpad if only mouse available is touchscreen #452

usr-sse2 opened this issue Aug 10, 2019 · 3 comments
Labels

Comments

@usr-sse2
Copy link
Contributor

VoodooI2C/VoodooI2C#147

@vit9696
Copy link
Contributor

vit9696 commented Mar 4, 2020

@usr-sse2 can you clarify why is that an error? I am afraid that we may not even have control over this, as it should be decided on macOS side, not on the driver side. I also believe that the behaviour is the same on iMacs with Magic Trackpad.

@usr-sse2
Copy link
Contributor Author

@vit9696 No, the control is on our side. See ApplePS2SynapticsTouchPad::notificationHIDAttachedHandlerGated. (But it may be the case that currently both we and macOS are disabling the trackpad – I haven't checked it. But when VoodooPS2 worked not through MT2 simulation, the system didn't control it).

This is an error because the semantics of this setting is to disable built-in pointing devices when an external pointing device is connected. Macs don't have built-in touchscreens, so for Macs it's all OK. Lenovo Yoga has a built-in touchscreen, so the checkbox becomes useless because it just disables the trackpad always.

@usr-sse2
Copy link
Contributor Author

usr-sse2 commented Apr 23, 2020

I checked, we are already checking the device class, and for touchscreen we're not disabling the trackpad, so macOS does it. Still the code in VoodooPS2 shouldn't be removed, because it also affects physical buttons and trackpoint, which are sent in bypass of MT2 simulator.

@usr-sse2 usr-sse2 added the wontfix This will not be worked on label Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants