Addressed nits on PR

acmucsd · Apr 17, 2024 · 5d96fa1 · 5d96fa1
1 parent 9f49655
commit 5d96fa1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/src/components/events/EventCard/index.tsx b/src/components/events/EventCard/index.tsx
@@ -74,10 +74,8 @@ const EventCard = ({
       <Link
         href={`${config.eventsRoute}/${uuid}`}
         data-community={community}
-        data-disabled={borderless ? 'true' : 'false'}
-        className={`${styles.container} ${borderless ? 'disabled' : styles.bordered} ${
-          className || ''
-        }`}
+        data-disabled={borderless}
+        className={`${styles.container} ${borderless ? '' : styles.bordered} ${className || ''}`}
         onClick={e => {
           e.preventDefault();
           setExpanded(true);

diff --git a/src/components/events/EventCard/style.module.scss b/src/components/events/EventCard/style.module.scss
@@ -20,7 +20,7 @@
     border-radius: 10px;
   }
 
-  &:not([data-disabled='true']):hover {
+  &:not([data-disabled]):hover {
     outline-width: 4px;
     transform: scale(0.975);
 

diff --git a/src/pages/store/cart.tsx b/src/pages/store/cart.tsx
@@ -252,7 +252,7 @@ const getServerSidePropsFunc: GetServerSideProps = async ({ req, res }) => {
     events
       .filter(event => event.status !== 'CANCELLED')
       .filter(
-        event => (event.orders?.length ?? 0) <= (event?.orderLimit ?? Number.MAX_SAFE_INTEGER)
+        event => !(event.orders && event.orderLimit && event.orders.length > event.orderLimit)
       )
   );
   const userPromise = getCurrentUserAndRefreshCookie(AUTH_TOKEN, { req, res });