From e534dbdfec5f34d64ba212cb015218b1534e4b66 Mon Sep 17 00:00:00 2001 From: Nikhil Dange Date: Sun, 12 Nov 2023 23:35:15 -0800 Subject: [PATCH 1/4] updated yml file --- .github/workflows/auto-comment.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/auto-comment.yml b/.github/workflows/auto-comment.yml index 8fd61929..87ea6f3d 100644 --- a/.github/workflows/auto-comment.yml +++ b/.github/workflows/auto-comment.yml @@ -4,10 +4,10 @@ jobs: run: runs-on: ubuntu-latest steps: - - uses: bubkoo/auto-comment@v1.0.7 + - uses: wow-actions/auto-comment@v1 with: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - pullRequestOpened: > + pullRequestOpened: | Thanks for contributing! If you've made changes to the API's functionality, please make sure to bump the package version—see [this guide to semantic versioning](https://semver.org/) for details—and From aeda07d4aee304e54c276a6bb91cb980b65e57a4 Mon Sep 17 00:00:00 2001 From: Nikhil Dange Date: Sat, 2 Dec 2023 12:04:19 -0800 Subject: [PATCH 2/4] crazy new pr template --- .github/PULL_REQUEST_TEMPLATE.md | 47 +++++++++++++++++++++++++++++++- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e5f86064..7a7bd64a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1 +1,46 @@ -Closes #[ISSUE-NUM]. +# Info + +Closes **[ISSUE NUMBER]**. (If there is no issue for this pull request yet, please create one or +delete this line if the pull request is for a very minor tweak). + +# Description + +What changes did you make? List all distinct problems that this PR addresses. Explain any relevant +motivation or context. + +[description] + +## Changes + +- [Fill in here] + +# Type of Change + +- [ ] Bug Fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Breaking change (fix or feature that would cause existing functionality to not work as + expected) +- [ ] Logistics Change (A change to a README, description, or dev workflow setup like + linting/formatting) +- [ ] Continuous Integration/DevOps Change (Related to deployment steps or continuous integration + workflows) +- [ ] Other: (Fill In) + +# Testing + +I have tested that my changes fully resolve the linked issue ... + +- [ ] locally. +- [ ] on the testing API/testing database. +- [ ] I have run and verified Postman routes. Screenshots are included below. + +# Checklist + +- [ ] I have performed a self-review of my own code. +- [ ] I have followed the style guidelines of this project. +- [ ] I have appropriately edited the API version in the `package.json` file. +- [ ] My changes produce no new warnings. + +# Screenshots + +Please include a screenshot of your Postman testing passing successfully. \ No newline at end of file From d6bcd02d639e6b7e7af1e56f77a98a519adb8caa Mon Sep 17 00:00:00 2001 From: Nikhil Dange Date: Sat, 2 Dec 2023 12:38:23 -0800 Subject: [PATCH 3/4] edited checklist --- .github/PULL_REQUEST_TEMPLATE.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7a7bd64a..e67212ab 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -16,16 +16,16 @@ motivation or context. # Type of Change -- [ ] Bug Fix (non-breaking change which fixes an issue) -- [ ] New feature (non-breaking change which adds functionality) -- [ ] Breaking change (fix or feature that would cause existing functionality to not work as +- [ ] Patch (non-breaking change/bugfix) +- [ ] Minor (non-breaking change which adds functionality) +- [ ] Major (fix or feature that would cause existing functionality to not work as expected) -- [ ] Logistics Change (A change to a README, description, or dev workflow setup like - linting/formatting) -- [ ] Continuous Integration/DevOps Change (Related to deployment steps or continuous integration - workflows) +- [ ] Documentation (A change to a README/description) +- [ ] Continuous Integration/DevOps Change (Related to deployment steps, continuous integration + workflows, linting, etc.) - [ ] Other: (Fill In) +If you've selected Patch, Minor, or Major as your change type, **make sure to bump the version before merging in `package.json`!** # Testing I have tested that my changes fully resolve the linked issue ... From 86fed9fecb9388121fbce23a4dc3c351d00ac794 Mon Sep 17 00:00:00 2001 From: Nikhil Dange Date: Sun, 3 Dec 2023 11:00:45 -0800 Subject: [PATCH 4/4] made it sound nicer --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e67212ab..ec52bdd8 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -32,7 +32,7 @@ I have tested that my changes fully resolve the linked issue ... - [ ] locally. - [ ] on the testing API/testing database. -- [ ] I have run and verified Postman routes. Screenshots are included below. +- [ ] with appropriate Postman routes. Screenshots are included below. # Checklist