Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Discord and Google Calendar Event ID columns #415

Merged
merged 9 commits into from
Apr 4, 2024

Conversation

echang594
Copy link
Contributor

@echang594 echang594 commented Mar 9, 2024

Info

Closes #413.

Description

What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.

  • Added columns in migrations
  • Added fields to request and response types, models, validators, and test factory

Changes

Type of Change

  • Patch (non-breaking change/bugfix)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (A change to a README/description)
  • Continuous Integration/DevOps Change (Related to deployment steps, continuous integration
    workflows, linting, etc.)
  • Other: (Fill In)

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally.
  • on the testing API/testing database.
  • with appropriate Postman routes. Screenshots are included below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have appropriately edited the API version in the package.json file.
  • My changes produce no new warnings.

Screenshots

Screenshot 2024-03-13 at 3 45 43 PM

Please include a screenshot of your Postman testing passing successfully.

Copy link

github-actions bot commented Mar 9, 2024

Thanks for contributing!
If you've made changes to the API's functionality, please make sure to bump the package
version—see this guide to semantic versioning for details—and
document those changes as appropriate.

@echang594 echang594 linked an issue Mar 9, 2024 that may be closed by this pull request
@echang594 echang594 changed the title Added discord and google calendar event columns Link Discord Event ID and Google Calendar Event ID to Events Mar 10, 2024
@echang594 echang594 changed the title Link Discord Event ID and Google Calendar Event ID to Events Add Discord and Google Calendar Event ID columns Mar 10, 2024
Copy link
Member

@nik-dange nik-dange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one microscopic nit before we merge srry I didn't see it earlier

@echang594 echang594 requested a review from nik-dange March 30, 2024 06:19
Copy link
Member

@nik-dange nik-dange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nik-dange nik-dange merged commit a7a674b into master Apr 4, 2024
5 checks passed
@echang594 echang594 deleted the Eric/link-event-ids branch April 4, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link Discord Event ID and Google Calendar Event ID to Events
2 participants