Add test.

acquia · May 24, 2024 · 584eb3d · 584eb3d
1 parent 88d7906
commit 584eb3d
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 7 deletions.
diff --git a/src/Helpers/TelemetryHelper.php b/src/Helpers/TelemetryHelper.php
@@ -107,11 +107,7 @@ public function initializeAmplitude(): void {
     }
   }
 
-  private function normalizeAhEnv(): string {
-    $ah_env = AcquiaDrupalEnvironmentDetector::getAhEnv();
-    if (AcquiaDrupalEnvironmentDetector::isAcsfEnv()) {
-      return 'acsf';
-    }
+  public static function normalizeAhEnv($ah_env): string {
     if (AcquiaDrupalEnvironmentDetector::isAhProdEnv($ah_env)) {
       return 'prod';
     }
@@ -127,7 +123,7 @@ private function normalizeAhEnv(): string {
     if (AcquiaDrupalEnvironmentDetector::isAhIdeEnv($ah_env)) {
       return 'ide';
     }
-    return AcquiaDrupalEnvironmentDetector::getAhEnv();
+    return $ah_env;
   }
 
   /**
@@ -138,7 +134,7 @@ private function normalizeAhEnv(): string {
   private function getTelemetryUserData(): array {
     $data = [
       'ah_app_uuid' => getenv('AH_APPLICATION_UUID'),
-      'ah_env' => $this->normalizeAhEnv(),
+      'ah_env' => $this->normalizeAhEnv(AcquiaDrupalEnvironmentDetector::getAhEnv()),
       'ah_group' => AcquiaDrupalEnvironmentDetector::getAhGroup(),
       'ah_non_production' => getenv('AH_NON_PRODUCTION'),
       'ah_realm' => getenv('AH_REALM'),

diff --git a/tests/phpunit/src/Misc/TelemetryHelperTest.php b/tests/phpunit/src/Misc/TelemetryHelperTest.php
@@ -67,5 +67,24 @@ public function testGetEnvironmentProviderWithoutAnyEnvSet(): void {
     // Expect null since no provider environment variables are set.
     $this->assertNull(TelemetryHelper::getEnvironmentProvider());
   }
+  public function providerTestAhEnvNormalization(): array {
+    return [
+      ['prod', 'prod'],
+      ['01live', 'prod'],
+      ['stage', 'stage'],
+      ['stg', 'stage'],
+      ['dev1', 'dev'],
+      ['ode1', 'ode'],
+      ['ide', 'ide'],
+    ];
+  }
+
+  /**
+   * @dataProvider providerTestAhEnvNormalization
+   */
+  public function testAhEnvNormalization($ah_env, $expected) {
+    $normalized_ah_env = TelemetryHelper::normalizeAhEnv($ah_env);
+    $this->assertEquals($expected, $normalized_ah_env);
+  }
 
 }