Skip to content

Commit

Permalink
fix uploads3 script
Browse files Browse the repository at this point in the history
  • Loading branch information
danepowell committed Apr 12, 2024
1 parent c600b34 commit c22318d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/upload-s3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
- name: Comment on PR
run: |
GITHUB_PR=${{ steps.pr.outputs.result }}
COMMENT="Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/builds/$GITHUB_SHA/acli.phar"
COMMENT="Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/$GITHUB_SHA/acli.phar\n```\ncurl -OL https://acquia-cli.s3.amazonaws.com/build/$GITHUB_SHA/acli.phar\nchmod +x acli.phar\n```"
COMMENT_URL="https://github.com/$GITHUB_REPOSITORY/pull/$GITHUB_PR"
gh pr comment --edit-last $COMMENT_URL --body "$COMMENT" || gh pr comment $COMMENT_URL --body "$COMMENT"
env:
Expand Down
9 changes: 5 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,11 @@ Pull requests must also adhere to the following guidelines:

Every commit on the Acquia CLI repository, including for pull requests, automatically builds and uploads acli.phar as a build artifact to assist with reviews. To download acli.phar for any commit:

1. Wait for the CI workflow to complete.
2. On the workflow summary page, in the "Artifacts" section, click on `acli.phar`.
3. Unzip the downloaded file.
4. Make the file executable: `chmod +x acli.phar`
1. For pull requests, GitHub Actions will comment on the PR with a link to the dev build.
2. For any other commit, wait for the CI workflow to complete.
3. On the workflow summary page, in the "Artifacts" section, click on `acli.phar`.
4. Unzip the downloaded file.
5. Make the file executable: `chmod +x acli.phar`

## Building and testing

Expand Down

0 comments on commit c22318d

Please sign in to comment.