From c22318d76bdaddeb7217c23e45c28aea23510f47 Mon Sep 17 00:00:00 2001 From: Dane Powell Date: Fri, 12 Apr 2024 11:41:25 -0700 Subject: [PATCH] fix uploads3 script --- .github/workflows/upload-s3.yml | 2 +- CONTRIBUTING.md | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/upload-s3.yml b/.github/workflows/upload-s3.yml index 5a964e6b0..d1eb809c7 100644 --- a/.github/workflows/upload-s3.yml +++ b/.github/workflows/upload-s3.yml @@ -62,7 +62,7 @@ jobs: - name: Comment on PR run: | GITHUB_PR=${{ steps.pr.outputs.result }} - COMMENT="Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/builds/$GITHUB_SHA/acli.phar" + COMMENT="Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/$GITHUB_SHA/acli.phar\n```\ncurl -OL https://acquia-cli.s3.amazonaws.com/build/$GITHUB_SHA/acli.phar\nchmod +x acli.phar\n```" COMMENT_URL="https://github.com/$GITHUB_REPOSITORY/pull/$GITHUB_PR" gh pr comment --edit-last $COMMENT_URL --body "$COMMENT" || gh pr comment $COMMENT_URL --body "$COMMENT" env: diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 507423da9..d31b2a302 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -43,10 +43,11 @@ Pull requests must also adhere to the following guidelines: Every commit on the Acquia CLI repository, including for pull requests, automatically builds and uploads acli.phar as a build artifact to assist with reviews. To download acli.phar for any commit: -1. Wait for the CI workflow to complete. -2. On the workflow summary page, in the "Artifacts" section, click on `acli.phar`. -3. Unzip the downloaded file. -4. Make the file executable: `chmod +x acli.phar` +1. For pull requests, GitHub Actions will comment on the PR with a link to the dev build. +2. For any other commit, wait for the CI workflow to complete. +3. On the workflow summary page, in the "Artifacts" section, click on `acli.phar`. +4. Unzip the downloaded file. +5. Make the file executable: `chmod +x acli.phar` ## Building and testing