Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1221: TypeError and warning in remote:alises:download #1636

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

danepowell
Copy link
Contributor

This has the side effect of throwing an exception when the Git config is invalid or missing, as opposed to before when it might still fall back to other methods of finding the application. I think it's a desirable change.

@danepowell danepowell added the bug Something isn't working label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b839f67) 91.93% compared to head (4e0e9bc) 91.93%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1636   +/-   ##
=========================================
  Coverage     91.93%   91.93%           
+ Complexity     1821     1820    -1     
=========================================
  Files           124      124           
  Lines          6513     6513           
=========================================
  Hits           5988     5988           
  Misses          525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell merged commit 7daef90 into acquia:main Nov 17, 2023
12 checks passed
@danepowell danepowell deleted the CLI-1221 branch September 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant