Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better detection of file arguments #4

Open
sbidoul opened this issue Mar 11, 2019 · 2 comments
Open

better detection of file arguments #4

sbidoul opened this issue Mar 11, 2019 · 2 comments

Comments

@sbidoul
Copy link
Member

sbidoul commented Mar 11, 2019

Currently, the client detects file arguments with a simple heuristics: an argument that does not start with - and corresponds to an existing file is considered a file argument.

This may break in rare situations where an existing file correspond to an argument name.

@sbidoul sbidoul added bug Something isn't working go client py client and removed bug Something isn't working labels Mar 11, 2019
@foutoucour
Copy link

Hey @sbidoul did you consider cobra to manage the arguments ?
It seems a good tool. I used it for some cli here at Numigi. It was super easy.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 22, 2019

Nope. Not sure it would help though. The problem is that we don't know (and don't want to reproduce) the exact cli of wkhtmltopdf. So I don't really know how to fix this bug, but it's probably not an issue in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants