Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logIncoming method produces unhandled promised rejections during request timeouts #41

Open
pgoldweic opened this issue Mar 29, 2021 · 1 comment

Comments

@pgoldweic
Copy link

The logIncoming method sometimes times out trying to send data to Dashbot. This unfortunately causes an exception that is thrown and is uncaught within it, which in turn may cause the containing node application to eventually exit with a non-zero error code (as unhandled promised rejections will eventually be deprecated). Note that it's of no use to wrap the call to this method with a try/catch block.

@pgoldweic
Copy link
Author

I'm just realizing that I might be able to 'await' the return of this method, which might be a work-around to resolve the problem. Could somebody confirm? On the other hand, I'd rather not have to do that if there is another solution (e.g. sending a callback function as a parameter to it-which could get called on error-, or something else). Please clarify. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant