Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

Dynamic transition of scenes has broken #43

Open
Topias-Pratsam opened this issue Sep 7, 2021 · 5 comments
Open

Dynamic transition of scenes has broken #43

Topias-Pratsam opened this issue Sep 7, 2021 · 5 comments

Comments

@Topias-Pratsam
Copy link

Dynamic transition of scenes has broken. Only transitions done in action builder work. Any transitions done in webhook are not registering.
https://developers.google.com/assistant/conversational/webhooks?tool=builder#transition_scenes

This was still working last week. Even older systems that have been properly tested have broken. Maybe the error has something to do with recent updates to assistant devices?

@Topias-Pratsam
Copy link
Author

Today it seems like the dynamic transition works in simulator, but not with Nest Hub or Google Home device. Yesterday it didn't work even in simulator.

@Topias-Pratsam
Copy link
Author

This is a critical bug that is completely ruining our user experience, is there a way to send this to firmware Action builder team fast?

Some information:

  • dynamic transitions seem to work sometimes
  • there does not seem to be pattern when it works and on what device. But 75% of the time the transition does not happen. Today it does not work even on simulator.
  • Sometimes it acts like action builder has half way changed the scene, and sometimes it has not at all:

Three examples, after dynamically transitioning new scene that has an intent which wasn't in old scene:

  1. Half way scene transition:
    Sometimes the error is "Did not find any handling for intent event 'intentOfNewScene' on scene 'OldScene'".
    which suggests that intentOfNewScene was triggered by users phrase but it could not be handled since AoG still thinks that we are in "OldScene" even thou "intentOfNewScene" does not exist on OldScene and should not be able to trigger from there.

  2. No transition at all
    Sometimes the the action on google just answers with fallback response as if the transition to new scene didn't happen at all.

  3. Rare successful transition
    Sometimes the dynamic transition does work.

@Fleker
Copy link
Member

Fleker commented Sep 14, 2021

Hey is there a case that I can reproduce? Does this happen with any sample projects? Is there an Actions SDK project you can provide as a zip?

@Topias-Pratsam
Copy link
Author

The dynamic transition is not used in sample projects. I made small project that has also has the required code for inline webhook. (see attachments)
Also added a picture of the error in actions console test. In the picture you can see the how scene is changing back.

What i found out while making this:

  • The bug only(?) happens when we add too much stuff in session in the OnEnter of the new scene.
  • it is very likely that there is a new limit to session size that enrolled to all actions. And the error messages are not explaining the error correctly. The maximum session size should probably be documented.

And if a breaking update is coming it would be nice to get a warning email before hand, so that we would have time to fix it.
Could a mailing list for new updates be added eventually? Also it would be nice to be able to test new updates to make sure they are not breaking our production.

scenebug

debugging_scenebug.zip

@Fleker
Copy link
Member

Fleker commented Sep 17, 2021

Thank you for putting this together. I've reproduced your error and have passed it to the team.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants