This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
do not override existing Cargo.lock #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene-babichenko
force-pushed
the
dont-override-cargo-lock
branch
from
d806ad5 to
a4d1867
Compare
mzabaluev
reviewed
May 10, 2021
| @@ -18,7 +19,9 @@ async function getData(): Promise<interfaces.Report> { | |||
| const cargo = await Cargo.get(); | |||
| await cargo.findOrInstall('cargo-audit'); | |||
|
|
|||
| await cargo.call(['generate-lockfile']); | |||
| if (!fs.existsSync('Cargo.lock')) { | |||
There was a problem hiding this comment.
Could use the async call (stat?) for extra nicety. Not sure if this will make any difference, though.
|
Any outstanding changes required on this PR that I can help with? Running into the same issue :) |
|
Not really, this branch is usable as it is. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #163
I could just remove that line, but I think this will break clients that rely on the existing behavior and would need a major release.