Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

excl-* config values are missing when running the action #91

Closed
3 tasks done
Enrico2 opened this issue Aug 27, 2020 · 2 comments
Closed
3 tasks done

excl-* config values are missing when running the action #91

Enrico2 opened this issue Aug 27, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@Enrico2
Copy link

Enrico2 commented Aug 27, 2020

Do the checklist before filing an issue:

Description

My .github/actions-rs/grcov.yml contains:

branch: true
ignore-not-existing: true
llvm: true
filter: covered
output-type: lcov
output-path: ./lcov.info
excl-line: "#\\[derive\\("
excl-br-line: "#\\[derive\\("
excl-start: "mod tests \\{"
excl-br-start: "mod tests \\{"

The debug statement when the action is run prints:

##[debug]User configuration: {"branch":true,"ignoreNotExisting":true,"llvm":true,"filter":"covered","outputType":"lcov","outputPath":"./lcov.info"}

It looks like the excl* config values are missing.

Workflow code

https://github.com/apollographql/rust/blob/8a2f4ca73c9529274661fcc710573c49b7647409/.github/workflows/coverage.yml

Action output

  env:
    CARGO_TERM_COLOR: always
    CARGO_INCREMENTAL: 0
    RUSTFLAGS: -Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests
    RUSTDOCFLAGS: -Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests
##[debug]User configuration: {"branch":true,"ignoreNotExisting":true,"llvm":true,"filter":"covered","outputType":"lcov","outputPath":"./lcov.info"}
::group::Searching for coverage files
Searching for coverage files
  Found project crates: apollo-query-planner,graphql-parser
  ##[debug]Creating an archive with coverage files at /tmp/coverage-wmwe4iwq1z.zip
  Archiving coverage file: /home/runner/work/rust/rust/target/debug/deps/apollo_query_planner-48cd324783e6f8e1.gcno
  Archiving coverage file: /home/runner/work/rust/rust/target/debug/deps/apollo_query_planner-9a2d2ac00302e9ac.gcda
  Archiving coverage file: /home/runner/work/rust/rust/target/debug/deps/apollo_query_planner-9a2d2ac00302e9ac.gcno
  Archiving coverage file: /home/runner/work/rust/rust/target/debug/deps/graphql_parser-13f552932c4a8288.gcda
  Archiving coverage file: /home/runner/work/rust/rust/target/debug/deps/graphql_parser-13f552932c4a8288.gcno
  Archiving coverage file: /home/runner/work/rust/rust/target/debug/deps/graphql_parser-989eb3afebc0a136.gcda
  Archiving coverage file: /home/runner/work/rust/rust/target/debug/deps/graphql_parser-989eb3afebc0a136.gcno
  Coverage files archive was created at the /tmp/coverage-wmwe4iwq1z.zip
  ::endgroup::
::group::Execute grcov
Execute grcov
  /usr/share/rust/.cargo/bin/grcov /tmp/coverage-wmwe4iwq1z.zip --branch --ignore-not-existing --llvm --commit-sha 8a2f4ca73c9529274661fcc710573c49b7647409 --filter covered --output-path /home/runner/work/rust/rust/lcov.info --output-type lcov --service-name Code Coverage --source-dir /home/runner/work/rust/rust
  ::endgroup::
Generated coverage report at /home/runner/work/rust/rust/lcov.info
::set-output name=report::/home/runner/work/rust/rust/lcov.info
##[debug]steps.coverage.outputs.report='/home/runner/work/rust/rust/lcov.info'
##[debug]Node Action run completed with exit code 0
##[debug]Finishing: Run actions-rs/[email protected]

Expected behavior

I believe the result of those options not showing up is that some lines are detected as not covered, e.g. all of the lines in the FetchGroup struct here: https://codecov.io/gh/apollographql/rust/src/8a2f4ca73c9529274661fcc710573c49b7647409/query-planner/src/groups.rs

@Enrico2 Enrico2 added the bug Something isn't working label Aug 27, 2020
@Enrico2 Enrico2 changed the title Seems like some config values are missing when running the action excl-* config values are missing when running the action Aug 27, 2020
@xnuter
Copy link

xnuter commented Sep 11, 2020

Seems to be a dup of #80 ?

@Enrico2
Copy link
Author

Enrico2 commented Sep 11, 2020

Yes seems like it.

@Enrico2 Enrico2 closed this as completed Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants