Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Action fails if binary already exists #6

Open
fengyc opened this issue Jun 28, 2020 · 5 comments · May be fixed by #8
Open

Action fails if binary already exists #6

fengyc opened this issue Jun 28, 2020 · 5 comments · May be fixed by #8
Labels
bug Something isn't working

Comments

@fengyc
Copy link

fengyc commented Jun 28, 2020

Description

Github action fails if binary already exists.

Workflow code

    - name: Rust install cargo-deb
      uses: actions-rs/[email protected]
      with:
        crate: cargo-deb
        version: latest

Action output

  Newest cargo-deb version available at crates.io: 1.24.0
  Downloading cargo-deb signature into /tmp/cargo-deb.zip.sig
  Downloading cargo-deb == 1.24.0 into /tmp/cargo-deb.zip
  Starting signature verification process
  /usr/bin/openssl dgst -sha256 -verify /home/runner/work/_actions/actions-rs/install/v0.1/public.pem -signature /tmp/cargo-deb.zip.sig /tmp/cargo-deb.zip
  Verified OK
  Extracting files into /home/runner/.cargo/bin
  /usr/bin/unzip /tmp/cargo-deb.zip
  Archive:  /tmp/cargo-deb.zip
  replace cargo-deb? [y]es, [n]o, [A]ll, [N]one, [r]ename: 
  ##[error]The operation was canceled.

Expected behavior

Need an option to ignore/replace binary if it exits.

Additional context

@fengyc fengyc added the bug Something isn't working label Jun 28, 2020
@matklad
Copy link

matklad commented Jul 16, 2020

matklad added a commit to rust-lang/rust-analyzer that referenced this issue Jul 16, 2020
Arzte added a commit to twilight-rs/twilight that referenced this issue Jul 16, 2020
The install workflow is currently broken, disabling it for now. actions-rs/install#6
Arzte added a commit to twilight-rs/twilight that referenced this issue Jul 16, 2020
The install workflow is currently broken, disabling it for now. actions-rs/install#6

Signed-off-by: Iris Hoffmeyer <[email protected]>
Approved-by: Valdemar Erk <[email protected]>
Approved-by: AEnterprise <[email protected]>
Merged-by: Iris Hoffmeyer <[email protected]>
antifuchs added a commit to boinkor-net/governor that referenced this issue Jul 25, 2020
It's currently hanging in CI, due to
actions-rs/install#6.
@antifuchs
Copy link

I dug, and it looks like the extractZip function doesn't appear to call unzip with the argument that makes it stop prompting. However, I couldn't find where that function is defined. ):

@Arzte
Copy link

Arzte commented Aug 11, 2020

Did a bit of digging and looks like extractZip is defined here https://github.com/actions/toolkit/blob/1cc56db0ff126f4d65aeb83798852e02a2c180c3/packages/tool-cache/src/tool-cache.ts#L324-L368 in actions/toolkit

Arzte added a commit to Arzte/install that referenced this issue Aug 11, 2020
Arzte added a commit to Arzte/install that referenced this issue Aug 11, 2020
@Arzte Arzte linked a pull request Aug 11, 2020 that will close this issue
72636c added a commit to 72636c/mdbook-svgbob that referenced this issue Jan 4, 2021
@Shadow53
Copy link

Shadow53 commented Sep 9, 2021

Just ran into this on some projects. The action fell back to using cargo install and suggested I use --force to make overwrite the previous installation (that was cached from a previous run).

@Haaroon
Copy link

Haaroon commented Mar 7, 2023

i alos have this issue, should not fail if it already exists

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

6 participants