Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action failing on MacOS Ventura Self-Hosted Runner #113

Open
iatanasov37 opened this issue Sep 8, 2023 · 1 comment
Open

Action failing on MacOS Ventura Self-Hosted Runner #113

iatanasov37 opened this issue Sep 8, 2023 · 1 comment

Comments

@iatanasov37
Copy link

iatanasov37 commented Sep 8, 2023

Hell there,

I've already opened a PR #112 with the first suggested solution from below in mind.

We have recently created a self-hosted runner with the following parameters:

Chip: Apple M1
MacOS: Ventura 13.5.1

Using that runner results in a failure of your action, due to a dependency of @actions/github - macos-release as seen in the stack trace below:

image

Below you may find the version of the faulty dependency and which version introduces a fix:
image

Fixed version:
image

Proposed Solutions

  • Less intrusive: Use overrides for the os-name package to it's latest release

    • Downside here is the fact that a new MacOS version is already in development and with it's release the action will require further maintenance
  • Requires core changes: Update @actions/github package to >=4.0.0, since it no longer depends on macos-release

    • Downside is that this bump leads to breaking changes with @octokit/rest and will require further review

Awaiting your thoughts!

@iatanasov37
Copy link
Author

@NamrataJha @s-anupam
Hello there.

With the new announcement from Github about the M1 Runners Public Beta I believe this issue will start coming up even more.

Also with the rollout of the latest macOS Sonoma, the action stands two OS versions behind because of the package macos-release package. Is there something that I can do to move the PR #112 forward?

Thank you for your cooperation in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant