Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Allow sub domains by default when checking proxy bypass #40

Open
Swiftwork opened this issue Mar 19, 2021 · 0 comments
Open

Allow sub domains by default when checking proxy bypass #40

Swiftwork opened this issue Mar 19, 2021 · 0 comments

Comments

@Swiftwork
Copy link

Currently the no_proxy environmental variable combined with checkBypass does not take into account sub domains. I don't know if this is by design, but an example of this is:

process.env['no_proxy'] = 'internal.com'
checkBypass(new Url('https://github.internal.com/path/to/repo')) // false

process.env['no_proxy'] = 'github.internal.com'
checkBypass(new Url('https://github.internal.com/path/to/repo')) // true

The offending line is:

if (upperReqHosts.some(x => x === upperNoProxyItem)) {

I would love to see a more lenient pattern, either respecting wildcards or ignoring sub domains.

Regards
Erik Hughes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant