Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging main into PR causes incorrect labeling #784

Open
2 of 5 tasks
jamesmehorter opened this issue May 23, 2024 · 4 comments
Open
2 of 5 tasks

Merging main into PR causes incorrect labeling #784

jamesmehorter opened this issue May 23, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@jamesmehorter
Copy link

jamesmehorter commented May 23, 2024

Description:
PR 1 is opened which has no changes matching patterns in labeler.yml, and as expected receives no labels, good. Meanwhile, PR 2 (which did match and receive a label, also good) is merged into main. Afterwards, merging main into PR 1 causes labeler to apply the same labels applied to PR 2, bad.

screen_shot_2024-05-22_at_4-20-07_pm

Action version:
v4

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:

  1. Create PR 1 which matches no rules in labeler.yml, confirm no labels are applied to PR 1
  2. Create PR 2 which does match rules in labeler.yml, confirm labels are applied to PR 2
  3. Merge PR 2 into main
  4. Merge main into PR 1, observe that PR 2s labels are applied to PR 1

Expected behavior:
Upon 4 above, no labels are applied to PR 1

Actual behavior:
Upon 4 above, labels are applied to PR 1

@jamesmehorter jamesmehorter added bug Something isn't working needs triage labels May 23, 2024
@jamesmehorter
Copy link
Author

I started to solve for this in our actions but thought I should post here first

Screen-Shot-2024-05-23-at-3-07-47-PM

Screen Shot 2024-05-23 at 3 07 31 PM

@HarithaVattikuti
Copy link
Contributor

Hello @jamesmehorter
Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.

@zzztimbo
Copy link

We are seeing a simliar issue as well.

@svrnm
Copy link

svrnm commented Nov 21, 2024

We see the same issue

Edit: another work around is restricting the activity types to opened and reopened and by that dropping synchronize, see here: "By default, a workflow only runs when a pull_request_target event's activity type is opened, synchronize, or reopened"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants