Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ubuntu] Added firefox to Ubuntu24.04 image #10553

Closed
wants to merge 3 commits into from
Closed

[Ubuntu] Added firefox to Ubuntu24.04 image #10553

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24b486d
Added firefox to Ubuntu24.04 image
Sep 4, 2024
f193667
Merge branch 'actions:main' into firefox
ijunaidm Sep 10, 2024
4a14eef
Update Browsers.Tests.ps1
ijunaidm Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions images/ubuntu/scripts/docs-gen/Generate-SoftwareReport.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,10 +225,9 @@ if ((Test-IsUbuntu20) -or (Test-IsUbuntu22)) {
$browsersTools.AddToolVersion("Microsoft Edge WebDriver", $(Get-EdgeDriverVersion))
}
$browsersTools.AddToolVersion("Selenium server", $(Get-SeleniumVersion))
if ((Test-IsUbuntu20) -or (Test-IsUbuntu22)) {
$browsersTools.AddToolVersion("Mozilla Firefox", $(Get-FirefoxVersion))
$browsersTools.AddToolVersion("Geckodriver", $(Get-GeckodriverVersion))
}
$browsersTools.AddToolVersion("Mozilla Firefox", $(Get-FirefoxVersion))
$browsersTools.AddToolVersion("Geckodriver", $(Get-GeckodriverVersion))


# Environment variables
$browsersTools.AddHeader("Environment variables").AddTable($(Build-BrowserWebdriversEnvironmentTable))
Expand Down
3 changes: 1 addition & 2 deletions images/ubuntu/scripts/tests/Browsers.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
Describe "Firefox" -Skip:((-not (Test-IsUbuntu20)) -and (-not (Test-IsUbuntu22))) {
Describe "Firefox"
It "Firefox" {
"firefox --version" | Should -ReturnZeroExitCode
}

It "Geckodriver" {
"geckodriver --version" | Should -ReturnZeroExitCode
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pester test structure is broken. The Describe section should be surrounded by { } characters.
e.g.

Describe "pack of tests" {
    It "sometest" {
        ... some code ...
    }
}


Describe "Chrome" {
It "Chrome" {
Expand Down
1 change: 1 addition & 0 deletions images/ubuntu/templates/ubuntu-24.04.pkr.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ provisioner "shell" {
"${path.root}/../scripts/build/install-container-tools.sh",
"${path.root}/../scripts/build/install-dotnetcore-sdk.sh",
"${path.root}/../scripts/build/install-gcc-compilers.sh",
"${path.root}/../scripts/build/install-firefox.sh",
"${path.root}/../scripts/build/install-gfortran.sh",
"${path.root}/../scripts/build/install-git.sh",
"${path.root}/../scripts/build/install-git-lfs.sh",
Expand Down