Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat req] Allow slashes in artifact name #647

Open
BernhardKoschicek opened this issue Nov 18, 2024 · 0 comments
Open

[feat req] Allow slashes in artifact name #647

BernhardKoschicek opened this issue Nov 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@BernhardKoschicek
Copy link

What would you like to be added?

At OpenAtlas we are using branch names with slashes, which is a widespread git naming convention.

Sadly, when using e.g. a branch name like feature/text-annotation actions/upload-artifact@v4 fails with following error message:

Error: The artifact name is not valid: OpenAtlas-feature/text-annotation-auto-deploy-values-yaml. Contains the following character:  Forward slash /
          
Invalid characters include:  Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n, Backslash \, Forward slash /
          
These characters are not allowed in the artifact name due to limitations with certain file systems such as NTFS. To maintain file system agnostic behavior, these characters are intentionally not allowed to prevent potential problems with downloads on different file systems.

The example take from the OpenAltas development (https://github.com/acdh-oeaw/OpenAtlas).

Why is this needed?

We understand, that allowing slashes cause other problems, but it would be nice if action work with standard git naming conventions.

@BernhardKoschicek BernhardKoschicek added the enhancement New feature or request label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant