Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Transport/Application API #80

Open
jakobod opened this issue Jun 30, 2020 · 0 comments
Open

Rename Transport/Application API #80

jakobod opened this issue Jun 30, 2020 · 0 comments

Comments

@jakobod
Copy link
Member

jakobod commented Jun 30, 2020

We should think about using more general naming for the transport and application protocol APIs. The Application layer is using a message-oriented communication model while the transport layer is using all different types depending on the transport protocol in use.
Hence, it would be more clear to rename write_packet in the transport abstraction to something more general such as send with some clear documentation about the underlying model (UDP->packet, SCTP->message, TCP->stream).
The same goes for handle_data in the application abstraction, which could be renamed to something along the lines of receive.

Do you have an opinion on that @Neverlord @josephnoir ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant