Skip to content

Commit

Permalink
Remove overwrite from upload-artifact (#97)
Browse files Browse the repository at this point in the history
It appears this is causing some wheels to not get uploaded to pypi.
  • Loading branch information
jameshilliard authored Sep 6, 2024
1 parent 89182ad commit dc66efc
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ jobs:
- uses: pypa/[email protected]
- uses: actions/upload-artifact@v4
with:
name: artifact-wheel-${{ matrix.os }}
path: wheelhouse/*.whl
overwrite: true

make_sdist:
runs-on: "ubuntu-latest"
Expand All @@ -54,11 +54,22 @@ jobs:
python -m build --no-isolation --sdist
- uses: actions/upload-artifact@v4
with:
name: artifact-sdist
path: dist/*.tar.gz
overwrite: true

upload_all:
merge:
runs-on: ubuntu-latest
needs: [build_wheels, make_sdist]
steps:
- name: Merge Artifacts
uses: actions/upload-artifact/merge@v4
with:
name: artifact
pattern: artifact-*
delete-merged: true

upload_all:
needs: merge
runs-on: "ubuntu-latest"
environment: release
if: github.event_name == 'release' && github.event.action == 'published'
Expand Down

0 comments on commit dc66efc

Please sign in to comment.