Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we migrate to pybind11 or merge with can_ada? #69

Open
anonrig opened this issue Apr 13, 2024 · 3 comments
Open

Should we migrate to pybind11 or merge with can_ada? #69

anonrig opened this issue Apr 13, 2024 · 3 comments

Comments

@anonrig
Copy link
Member

anonrig commented Apr 13, 2024

@TkTech did an amazing job with https://github.com/TkTech/can_ada. I think we should follow the path, or maybe merge the two implementations, since it is 2 times faster and the goal of Ada project is performance?

What do you think @lemire @TkTech @bbayles?

@TkTech
Copy link

TkTech commented Apr 14, 2024

can_ada is under the MIT license, so feel free to use it however you like. I believe it's complete as-is, or you can copy parts of it, fork it, whatever. There's also an experimental variation using nanobind which has a smaller range of supported versions and a more complicated build, but offers another ~30% speed boost.

@Master-Hash
Copy link
Contributor

What about the URL class? Without it, it may be a break change.

@bbayles
Copy link
Collaborator

bbayles commented Apr 14, 2024

I don't mind, but will bow out as maintainer rather than do the rewrite. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants