Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM-based testing with sanitizers in continuous integration #520

Closed
lemire opened this issue Sep 30, 2023 · 2 comments · Fixed by #649
Closed

Add ARM-based testing with sanitizers in continuous integration #520

lemire opened this issue Sep 30, 2023 · 2 comments · Fixed by #649
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lemire
Copy link
Member

lemire commented Sep 30, 2023

Currently, we run benchmarks with sanitizers in CI only on x64 hardware:

https://github.com/ada-url/ada/blob/main/.github/workflows/ubuntu-sanitized.yml

We need to add ARM-based sanitized tests to avoid issues such as #519 and nodejs/node#49960

@anonrig anonrig added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 10, 2023
@CarlosEduR
Copy link
Member

We'd need something like this, right, @lemire? https://github.com/marketplace/actions/arm-runner

I am interested in colaborating, just checking more about the options we have to use ARM.

@lemire
Copy link
Member Author

lemire commented May 3, 2024

More like this: https://github.com/simdutf/simdutf/blob/master/.github/workflows/aarch64.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants