Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme.md instructions not working #3

Open
SuperElectron opened this issue Nov 4, 2019 · 2 comments
Open

readme.md instructions not working #3

SuperElectron opened this issue Nov 4, 2019 · 2 comments

Comments

@SuperElectron
Copy link

Followed the instructions and your package isn't working. It looks great and I hope to get it working for what I am trying to do!

@Guber
Copy link

Guber commented Nov 14, 2019

Yeah I had to change few things to get it to run:

  • to get through module report not found errors, report module needs to be relative imported (from .report instead of from report in runner.py)
  • line 71 in runner.py, method _get_report , had to add encoding="utf-8" to open method to get rid of UnicodeDecodeError
  • line 75 in runner.py, method _clean, had to wrap os.remove with try except for OSError to get rid of WIn32 Permission Error
    -finally line 95 in report.py had to wrap v.get('score', 0) with or 0 => (v.get('score', 0) or 0) as get method returned None although it had a default value...

@adamcupial
Copy link
Owner

@Guber can you PR if you have made those changes?
Also - see lighthouse-ci, google has just shipped it, it's a CI-compatible lighthouse at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants