Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eager loading and chunking #13

Open
pulkitjalan opened this issue Dec 4, 2014 · 5 comments
Open

Eager loading and chunking #13

pulkitjalan opened this issue Dec 4, 2014 · 5 comments

Comments

@pulkitjalan
Copy link

Hi @adamfairholm,

I don't know if you would be up for merging this in, but I thought there were some things missing from this great package. Eager loading relationships and also indexing using chunking, more specifically the reindex and addAllToIndex not chunking. I have made these and some other changes on a fork. If you get some time please have a look and let me know if its something you would be happy to merge in and I will make a pull request.

https://github.com/clowdy/Elasticquent/tree/relations

@adamfairholm
Copy link
Owner

Hi @pulkitjalan - sorry for the delay. This looks great, and something that I'd love to get into this repo, and there are a lot of great other changes in here as well. Let me pull this down and give it a try over the next day or so, and then I'll probably set up a new branch for you to make the pull request to.

@pulkitjalan
Copy link
Author

Thats great, looking forward to it. Just a quick note, I added facets to
the response collection before I knew it was deprecated. I'll will be
removing that soon.
On 2 Jan 2015 04:30, "Adam Fairholm" [email protected] wrote:

Hi @pulkitjalan https://github.com/pulkitjalan - sorry for the delay.
This looks great, and something that I'd love to get into this repo, and
there are a lot of great other changes in here as well. Let me pull this
down and give it a try over the next day or so, and then I'll probably set
up a new branch for you to make the pull request to.


Reply to this email directly or view it on GitHub
#13 (comment)
.

@pulkitjalan
Copy link
Author

Hi @adamfairholm Please use this new branch instead of the other one. I have removed facets from it.

https://github.com/clowdy/Elasticquent/tree/improvements

@adamfairholm
Copy link
Owner

Hi @pulkitjalan - Sorry for the delay - I am going to take a look at this this weekend. Thanks!

@pulkitjalan
Copy link
Author

Hi @adamfairholm have you had a chance to look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants