-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eager loading and chunking #13
Comments
Hi @pulkitjalan - sorry for the delay. This looks great, and something that I'd love to get into this repo, and there are a lot of great other changes in here as well. Let me pull this down and give it a try over the next day or so, and then I'll probably set up a new branch for you to make the pull request to. |
Thats great, looking forward to it. Just a quick note, I added facets to
|
Hi @adamfairholm Please use this new branch instead of the other one. I have removed facets from it. |
Hi @pulkitjalan - Sorry for the delay - I am going to take a look at this this weekend. Thanks! |
Hi @adamfairholm have you had a chance to look at this? |
Hi @adamfairholm,
I don't know if you would be up for merging this in, but I thought there were some things missing from this great package. Eager loading relationships and also indexing using chunking, more specifically the
reindex
andaddAllToIndex
not chunking. I have made these and some other changes on a fork. If you get some time please have a look and let me know if its something you would be happy to merge in and I will make a pull request.https://github.com/clowdy/Elasticquent/tree/relations
The text was updated successfully, but these errors were encountered: