-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative to testMavenRepo for examples #73
Comments
Thanks for raising this. Currently the dokkatoo/examples/build.gradle.kts Lines 6 to 20 in 98a1c0b
If you want to generate the dokkatoo/buildSrc/src/main/kotlin/buildsrc/conventions/dokkatoo-example-projects.gradle.kts Lines 40 to 77 in 98a1c0b
If custom properties are needed then they can be hardcoded into the task for now. So long as you get something working, then it can be made prettier later! I had a lot of trouble trying to set up composite builds with Gradle, it's just too buggy gradle/gradle#23939, so Dokkatoo doesn't use it. |
I've cooked up a nice DSL for amending the dokkatoo/modules/dokkatoo-plugin-integration-tests/build.gradle.kts Lines 161 to 171 in 3cd790c
It's in a branch at the moment, and will be available when #76 is merged. |
Currently, the examples expect a
testMavenRepo
property to be defined, which is automatically generated by theupdateDokkatooExamplesGradleProperties
task in agradle.properties
file. However, this file doesn't appear to be generated when adding the examples asincludedBuild
s and running the Tests workflow - see this build step's logs:Additionally, some examples might want to add custom properties of their own, or the plugins/code used (for e.g. Kotlin Multiplatform) expects a property (in this case,
kotlin.mpp.androidSourceSetLayoutVersion=2
/kotlin.mpp.androidSourceSetLayoutVersion1.nowarn=true
to be set) to use a specific feature.I'm not sure as to a better approach of doing this - maybe it could be defined as a custom property in a custom
.properties
file, which can then be loaded in viajava.util.Properties
, or maybe as an environment variable?The text was updated successfully, but these errors were encountered: