Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed item isnt marked as read if opened in new tab using the link context menu #2

Open
eggsgent opened this issue Oct 26, 2018 · 2 comments

Comments

@eggsgent
Copy link

Using version 0.2.1

  1. Right click on a feed item and select to open in a new tab
  2. Go back to the feed and inspect feed item status

Expected result: Feed item should be marked as read
Actual result: Feed is marked with blue dot / in unread state

@adamsanderson
Copy link
Owner

This is slightly tricky since read/unread state is currently not aware of your current browsing, and I want to make sure Brook has a minimal impact on browsing performance. That said, I think we can hook tab loading, and check it against the currently selected feed's items. That should be cheap and get the expected behavior.

@eggsgent
Copy link
Author

eggsgent commented Nov 4, 2018

Ok, thanks for looking into it, I enjoy the minimal approach very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants