Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handling of 'general approach ' / 'restricted approach' for graph game BDD #97

Open
annyanich opened this issue Oct 23, 2020 · 1 comment
Assignees

Comments

@annyanich
Copy link
Collaborator

The nice way to implement this feature (with the buttons inside the tab on the right-hand panel) would have been to just open the tab fully client-side and not send any request to the server until the user pressed the button to choose between the two approaches.

Unfortunately, I implemented the tabs assuming that one tab <-> one Job object on the server.
I wrote the client in Javascript and not Typescript, and as a result, it is kind of hard to understand it and refactor it to allow tabs that are not jobs while feeling confident that the refactoring will be a success.

As a result of that, and because we are on a deadline, I have instead implemented this feature in a slightly hacky way to avoid performing that tricky refactoring.

The places that need to be rewritten include basically everything I added in the branch for #82. I will also put TODOs in some specific spots that may not be so obvious.

annyanich added a commit that referenced this issue Oct 23, 2020
I wrote a TODO and a comment about why this is necessary.
See issue #97.
@annyanich annyanich self-assigned this Oct 23, 2020
@mgieseking
Copy link
Member

I improved a little bit the display of this, but now I really like it and don't see all your hacking. Perfect ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants