Internationalization support #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if @adamtootle has had a chance to review this request, but it's a great thing to include. I honestly don't know how I didn't realize before that the strings weren't localized. I haven't tested your changes, but it looks good based on reviewing the changes, this pull request has my support. |
|
I'm taking a look at this this week. Thanks for the work so far on this feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds internationalization support as described in this official document.
Such a feature will unlock to the users the ability to give new translation using the plugin's GlotPress section.
Of course it's only a starter, to fully support internationalization you'll have to follow the instructions and use the GetText macros all over the source files instead of hardcoded translations.