Merge pull request #97 from JesseLeite/bugfix-unnecessary-array-filter

Unnecessary array_filter?
adamwathan · May 10, 2016 · 8056cea · 8056cea
2 parents 942f107 + 1cd183f
commit 8056cea
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/AdamWathan/Form/Binding/BoundData.php b/src/AdamWathan/Form/Binding/BoundData.php
@@ -23,7 +23,7 @@ public function data()
 
     protected function dotGet($dotKey, $default)
     {
-        $keyParts = array_filter(explode('.', $dotKey));
+        $keyParts = explode('.', $dotKey);
 
         return $this->dataGet($this->data, $keyParts, $default);
     }

diff --git a/tests/BindingTest.php b/tests/BindingTest.php
@@ -205,6 +205,26 @@ public function testBindNestedArrayWithMissingKey()
         $this->assertEquals($expected, $result);
     }
 
+    public function testBindArrayWithZeroAsKey()
+    {
+        $array = [
+            'hotdog' => [
+                0 => 'Tube',
+                1 => 'Steak',
+            ],
+        ];
+
+        $this->form->bind($array);
+
+        $expected = '<input type="text" name="hotdog[0]" value="Tube">';
+        $result = (string) $this->form->text('hotdog[0]');
+        $this->assertEquals($expected, $result);
+
+        $expected = '<input type="text" name="hotdog[1]" value="Steak">';
+        $result = (string) $this->form->text('hotdog[1]');
+        $this->assertEquals($expected, $result);
+    }
+
     public function testBindNestedObject()
     {
         $object = json_decode(json_encode([