Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce experimental feature warning #2622

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

danieljanes
Copy link
Member

Issue

Description

Every now and then, we introduce experimental features in Flower. So far, there is no consistent way to inform the user about the experimental nature of a feature.

Related issues/PRs

Once this PR is merged, PR #2393 can be updated to use warn_experimental_feature

Proposal

Explanation

This PR introduces a utility function warn_experimental_feature that we can use to log a warning every time a user uses an experimental feature. In addition to that, once we use the utility throughout the codebase, it will also allow us to easily search for experimental features.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

@danieljanes danieljanes enabled auto-merge (squash) November 21, 2023 10:56
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Looks good!

@danieljanes danieljanes merged commit 8bcc4bd into main Nov 21, 2023
27 checks passed
@danieljanes danieljanes deleted the warn-experimental-feature branch November 21, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants