feat(framework) Add flwr login protos #4244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnugraha
requested review from
danieljanes and
tanertopal
as code owners
panh99
reviewed
Nov 27, 2024
| @@ -52,3 +57,9 @@ message ListRunsResponse { | |||
| map<uint64, Run> run_dict = 1; | |||
| string now = 2; | |||
| } | |||
|
|
|||
| message LoginRequest {} | |||
| message LoginResponse { map<string, string> login_details = 1; } | |||
There was a problem hiding this comment.
Could we list out the login details needed, instead of using a dictionary? Just to make it clear.
Comment on lines
+64
to
+65
| message GetAuthTokenRequest { map<string, string> auth_details = 1; } | ||
| message GetAuthTokenResponse { map<string, string> auth_tokens = 1; } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
There is no auth mechanism for user to a
SuperLink.Related issues/PRs
Proposal
Explanation
Add protos as endpoints for user to a
SuperLink.Checklist
#contributions)Any other comments?