Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove legacy nav btn float #93

Closed
kirsty-hames opened this issue Mar 13, 2024 · 0 comments · Fixed by #94
Closed

remove legacy nav btn float #93

kirsty-hames opened this issue Mar 13, 2024 · 0 comments · Fixed by #94
Assignees
@kirsty-hames
Labels
enhancement

Comments

@kirsty-hames
Copy link
Contributor

Subject of the issue

The nav button float style is no longer required since the plugin was updated to support data-order.

Core also overrides any .nav__btn float styles.
@kirsty-hames kirsty-hames self-assigned this Mar 13, 2024
@kirsty-hames kirsty-hames moved this from New to Assigned in adapt_framework: The TODO Board Mar 13, 2024
@kirsty-hames kirsty-hames mentioned this issue Mar 13, 2024
Merged
@kirsty-hames kirsty-hames moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Mar 13, 2024
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: remove legacy nav btn float (fixes #93) adaptlearning/adapt-contrib-languagePicker
1 participant
@kirsty-hames