Update: Alert screen reader users when content has been added (fixes #232) #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swashbuck
changed the title
…urn childrenAdded from controller continue()
|
|
||
| // Rough estimate: 200ms per word + buffer | ||
| const words = message.split(' ').length; | ||
| const delay = (words * 200) + 300; |
There was a problem hiding this comment.
Happy with this? Did it all work as expected? Does it need a wider device test?
There was a problem hiding this comment.
It works well except when using feedback popups. When you close the popup, the focus moves to the disabled Submit button and announces it. So, the "loading" message is spoken over and never heard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232
🚧 Work in progress 🚧
Update
_globals._extensions._trickle.additionalContentLoadedin course.jsonFix
Testing