Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.12 support for MacOS #449

Closed
efecan-circlelabs opened this issue Dec 1, 2023 · 2 comments · Fixed by #460
Closed

Python 3.12 support for MacOS #449

efecan-circlelabs opened this issue Dec 1, 2023 · 2 comments · Fixed by #460
Labels
bug Something isn't working

Comments

@efecan-circlelabs
Copy link

Hello,

lxml is pinned to 4.9.2 for MacOS/Darwin and this is breaking Python 3.12 support.
https://github.com/adbar/trafilatura/blob/master/setup.py#L118

I'm not exactly sure why it's only pinned for MacOS so please advise, I'd be more than happy to make a PR.
@adbar adbar added the question Further information is requested label Dec 1, 2023
@adbar
Copy link
Owner

adbar commented Dec 1, 2023

Hi @efecan-circlelabs, I don't exactly remember what happened but there was a failure in CI/CD on Github Actions.

Feel free to draft a PR to update the setup.py and .github/workflows/tests.yml files and let's see how that goes.

You could add new python versions by following this existing template:

          - os: macos-latest
            python-version: 3.8

@efecan-circlelabs
Copy link
Author

efecan-circlelabs commented Dec 4, 2023 •
edited
Loading

Hey @adbar thanks for the info!

I've tracked it down to the htmldate dependency for this repo , which has the problematic lxml pinning for MacOS.
https://github.com/adbar/htmldate/blob/master/setup.py#L121-L122

I'll close this issue as for the mean-time I've forked both repos, and removed the pinning, which has solved my problem.

Not sure why they have that pinned either, I'll open up an issue on their repo and circle-back here if it gets resolved.

adbar/htmldate#113

adamh-oai added a commit to adamh-oai/htmldate that referenced this issue Dec 6, 2023
@adamh-oai
Unpin lxml
e9fa9e8 
Per adbar/trafilatura#449, see if unpinning
lxml works on MacOS.
@adamh-oai adamh-oai mentioned this issue Dec 6, 2023
Merged
@adbar adbar reopened this Dec 21, 2023
@adbar adbar linked a pull request Dec 21, 2023 that will close this issue
fix setup, update htmldate and add tests #460
Merged
@adbar adbar added bug Something isn't working and removed question Further information is requested labels Dec 21, 2023
adbar added a commit to adbar/htmldate that referenced this issue Dec 22, 2023
@adamh-oai @adbar
MacOS fix: change lxml setup (#114)
69310fa 
* Unpin lxml

Per adbar/trafilatura#449, see if unpinning
lxml works on MacOS.

* specify versions and add platform test

* further specify, add tests

* reduce number of tests

---------

Co-authored-by: Adrien Barbaresi <[email protected]>
Co-authored-by: Adrien Barbaresi <[email protected]>
@adbar adbar closed this as completed in #460 Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix setup, update htmldate and add tests adbar/trafilatura
2 participants
@adbar @efecan-circlelabs