Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ORM field not saved #8

Open
1 task done
maximeallanic opened this issue Mar 27, 2023 · 0 comments
Open
1 task done

[BUG] ORM field not saved #8

maximeallanic opened this issue Mar 27, 2023 · 0 comments

Comments

@maximeallanic
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

What browsers are you seeing the problem on?

Chrome

What operating system are you seeing the problem on?

Linux

Current Behavior

Quand on modifie par exemple product.category.name, et qu'on fait product.category.$save(). Le nom n'est pas sauvegardé.
J'ai regardé un peu plus dans l'ORM, quand on modifie le champ d'un objet (object.objectField.field) il n'est pas marqué "isChanged" et comme l'ORM n'envoie que les changements à firestore, le champ n'est pas sauvegardé.
Pour info, si "objectField" est un array, le champ est bien sauvegardé (par ex: product.variants[0].name)

Expected Behavior

si on modifie un champs object.objectField.field, le champ doit être sauvegardé.

Steps To Reproduce

Sur la PR https://github.com/track2max/application/pull/352
Modifier un produit
Changer le commentaire
Sauvegarder
Recharger la page
Modfier le même produit, le commentaire a disparu

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant