Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

CsvReporterConfig returns null if directory exists #24

Open
anupbanerjee opened this issue Jun 20, 2016 · 0 comments
Open

CsvReporterConfig returns null if directory exists #24

anupbanerjee opened this issue Jun 20, 2016 · 0 comments

Comments

@anupbanerjee
Copy link

Class: CsvReporterConfig
Method: enable
Line 39: File foutDir = createFile();
The line above invokes the Parent AbstractCsvReporterConfig's createFile() method.
In createFile() method's
Line Number 45: boolean success = foutDir.mkdirs();
This method will return false, if the directory already exists.
Since the value returned is false in CsvReporterConfig the enable method will return false.
I don't know if this is correct implementation, the reporter should continue to update the CSV files if the directory and file already exists.

ianilsley added a commit to ianilsley/metrics-reporter-config that referenced this issue Jun 22, 2016
This should address issue addthis#24 - addthis#24 .
@ianilsley ianilsley mentioned this issue Jun 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant