Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Find index with empty string. #41

Merged

Conversation

EdwinBetanc0urt
Copy link
Contributor

When searching with an empty text in a parameter, it is considered as part of the index because it is not null, so it is not marked as an empty mandatory.

imagen

imagen

@yamelsenih
Copy link
Member

Hey, just validate this and is ok: https://github.com/adempiere/dictionary_rs/blob/main/src/bin/server.rs#L333

@EdwinBetanc0urt
Copy link
Contributor Author

@yamelsenih It is validated if the variable is not null but not if it has an empty string, if you send language= it will not say that it is mandatory and considers it a valid value.

@yamelsenih yamelsenih merged commit fd84deb into adempiere:main Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants