Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberFormatException at Genre TypeConverter #39

Open
titanwalking opened this issue Jan 21, 2021 · 3 comments
Open

NumberFormatException at Genre TypeConverter #39

titanwalking opened this issue Jan 21, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@titanwalking
Copy link

A NumberFormatException occurs when app tries to map an empty String into a List of Long values; since genreIds String can be an empty one.

Responsible Line: com.adesso.movee.internal.util.typeconverter.GenreConverter.fromString(GenreConverter.kt:10)

@titanwalking titanwalking added the bug Something isn't working label Jan 21, 2021
@murattuzel
Copy link
Contributor

You are absolutely right about it, it should handle empty strings as well. Thanks for pointing that out. I can take the issue unless anyone else wants to.

@titanwalking
Copy link
Author

You are absolutely right about it, it should handle empty strings as well. Thanks for pointing that out. I can take the issue unless anyone else wants to.

Thanks Murat, appriciated, take it if you have some spare time.

@berkakbas
Copy link
Contributor

I believe the issue has been solved by @titanwalking's commit on Feb 15. Shall we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants