-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fastboot Compatibility? #10
Comments
As discussed in #11, this is definitely something we want to support. We also should add tests (https://github.com/kaliber5/ember-fastboot-addon-tests) for this to ensure full compatibility. We look forward to you contributing to this project! |
By the way: How did you find this addon? Do you have any use cases for this yet? |
Hey, I'm happy to add the tests. I wanted to make sure y'all were interested before I went too far. I found the addon via Google. I'm rebuilding a hybrid Ember app and UIKit seemed like a good fit. I have started implementing some more components and will contribute back as I finish them up. |
#14 adds fastboot compatibility so the only thing which is still missing is fastboot tests |
Sorry I totally ghosted on this. I didn't have much luck with fastboot-addon-tests. FWIW, i got the same errors trying to run the fastboot tests in ember-bootstrp. I'm clearly doing something wrong or something isn't configured right. Sorry, I just haven't had time to fight with it again. |
I don't know if y'all are interested in this, but I'm going to make a PR.
Currently, running ember-uikit in fastboot throws an error due to
document
not being defined in fastboot.Thanks for getting this wrapper started. I'm looking forward to contributing more.
The text was updated successfully, but these errors were encountered: