diff --git a/timed/authentication.py b/timed/authentication.py index 0242d241..491299ef 100644 --- a/timed/authentication.py +++ b/timed/authentication.py @@ -12,7 +12,7 @@ class TimedOIDCAuthenticationBackend(OIDCAuthenticationBackend): - def get_introspection(self, access_token, *args, **kwargs): + def get_introspection(self, access_token, _id_token, _payload): """Return user details dictionary.""" basic = base64.b64encode( f"{settings.OIDC_RP_INTROSPECT_CLIENT_ID}:{settings.OIDC_RP_INTROSPECT_CLIENT_SECRET}".encode() @@ -57,7 +57,7 @@ def get_userinfo_or_introspection(self, access_token): return claims raise AuthenticationFailed from exc - def get_or_create_user(self, access_token, *args, **kwargs): + def get_or_create_user(self, access_token, _id_token, _payload): """Verify claims and return user, otherwise raise an Exception.""" claims = self.get_userinfo_or_introspection(access_token) diff --git a/timed/employment/views.py b/timed/employment/views.py index 7c316e96..9548aae6 100644 --- a/timed/employment/views.py +++ b/timed/employment/views.py @@ -101,14 +101,14 @@ def get_queryset(self): return queryset @action(methods=["get"], detail=False) - def me(self, request, *args, **kwargs): + def me(self, request, _pk=None): self.object = get_object_or_404(get_user_model(), pk=request.user.id) serializer = self.get_serializer(self.object) return Response(serializer.data) @action(methods=["post"], detail=True) - def transfer(self, *args, **kwargs): + def transfer(self, _request, pk=None): # noqa: ARG002 """Transfer worktime and absence balance to new year. It will skip any credits if a credit already exists on the first diff --git a/timed/permissions.py b/timed/permissions.py index 54a26bd8..a5d5b525 100644 --- a/timed/permissions.py +++ b/timed/permissions.py @@ -18,50 +18,50 @@ def has_object_permission(self, _request, _view, obj): class IsReadOnly(BasePermission): """Allows read only methods.""" - def has_permission(self, request, *args, **kwargs): + def has_permission(self, request, _view): return request.method in SAFE_METHODS - def has_object_permission(self, request, view, *args, **kwargs): + def has_object_permission(self, request, view, _obj): return self.has_permission(request, view) class IsDeleteOnly(BasePermission): """Allows only delete method.""" - def has_permission(self, request, *args, **kwargs): + def has_permission(self, request, _view): return request.method == "DELETE" - def has_object_permission(self, request, view, *args, **kwargs): + def has_object_permission(self, request, view, _obj): return self.has_permission(request, view) class IsNotDelete(BasePermission): """Disallow delete method.""" - def has_permission(self, request, *args, **kwargs): + def has_permission(self, request, _view): return request.method != "DELETE" - def has_object_permission(self, request, view, *args, **kwargs): + def has_object_permission(self, request, view, _obj): return self.has_permission(request, view) class IsCreateOnly(BasePermission): """Allows only create method.""" - def has_permission(self, request, *args, **kwargs): + def has_permission(self, request, _view): return request.method == "POST" - def has_object_permission(self, request, view, *args, **kwargs): + def has_object_permission(self, request, view, _obj): return self.has_permission(request, view) class IsUpdateOnly(BasePermission): """Allows only update method.""" - def has_permission(self, request, *args, **kwargs): + def has_permission(self, request, _view): return request.method in ["PATCH", "PUT"] - def has_object_permission(self, request, view, *args, **kwargs): + def has_object_permission(self, request, view, _obj): return self.has_permission(request, view) @@ -72,7 +72,7 @@ class IsAuthenticated(IsAuthenticated): operator. """ - def has_object_permission(self, request, view, *args, **kwargs): + def has_object_permission(self, request, view, _obj): return self.has_permission(request, view) @@ -154,7 +154,7 @@ def has_permission(self, request, view): return request.user.is_superuser - def has_object_permission(self, request, view, *args, **kwargs): + def has_object_permission(self, request, view, _obj): return self.has_permission(request, view) diff --git a/timed/projects/admin.py b/timed/projects/admin.py index d0a552b5..41806155 100644 --- a/timed/projects/admin.py +++ b/timed/projects/admin.py @@ -95,7 +95,7 @@ class TaskInline(NestedStackedInline): extra = 0 inlines = (TaskAssigneeInline,) - def has_delete_permission(self, *args, **kwargs): + def has_delete_permission(self, _request, _obj): # for some reason obj is parent object and not task # so this doesn't work return False diff --git a/timed/subscription/views.py b/timed/subscription/views.py index e826df53..1cb08ec4 100644 --- a/timed/subscription/views.py +++ b/timed/subscription/views.py @@ -99,7 +99,7 @@ def create(self, request, *args, **kwargs): methods=["post"], permission_classes=[IsSuperUser | IsAccountant], ) - def confirm(self, request, *args, **kwargs): + def confirm(self, request, pk=None): # noqa: ARG002 """Confirm order. Only allowed by staff members @@ -114,7 +114,7 @@ def confirm(self, request, *args, **kwargs): def get_queryset(self): return models.Order.objects.select_related("project") - def destroy(self, *args, **kwargs): + def destroy(self, _request, pk=None): # noqa: ARG002 instance = self.get_object() if instance.acknowledged: # acknowledge orders may not be deleted diff --git a/timed/tracking/filters.py b/timed/tracking/filters.py index 7303f4a6..a0af6d17 100644 --- a/timed/tracking/filters.py +++ b/timed/tracking/filters.py @@ -45,7 +45,7 @@ class ActivityActiveFilter(Filter): """ @boolean_filter - def filter(self, qs, *args, **kwargs): + def filter(self, qs, _value): """Filter the queryset. :param QuerySet qs: The queryset to filter diff --git a/timed/tracking/views.py b/timed/tracking/views.py index aab2aa7b..366c0ea7 100644 --- a/timed/tracking/views.py +++ b/timed/tracking/views.py @@ -191,7 +191,7 @@ def update(self, request, *args, **kwargs): methods=["get"], serializer_class=serializers.ReportIntersectionSerializer, ) - def intersection(self, *args, **kwargs): + def intersection(self, _request): """Get intersection in reports of common report fields. Use case is for api caller to know what fields are the same